1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:27:36 +00:00

Everywhere: Rename to_{string => deprecated_string}() where applicable

This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
This commit is contained in:
Linus Groh 2022-12-06 01:12:49 +00:00 committed by Andreas Kling
parent 6e19ab2bbc
commit 57dc179b1f
597 changed files with 1973 additions and 1972 deletions

View file

@ -560,7 +560,7 @@ void canonicalize_unicode_extension_values(StringView key, DeprecatedString& val
// FIXME: Subdivision subtags do not appear in the CLDR likelySubtags.json file.
// Implement the spec's recommendation of using just the first alias for now,
// but we should determine if there's anything else needed here.
value = aliases[0].to_string();
value = aliases[0].to_deprecated_string();
}
}
}
@ -903,10 +903,10 @@ DeprecatedString resolve_most_likely_territory_alias(LanguageID const& language_
return territory.release_value();
}
return aliases[0].to_string();
return aliases[0].to_deprecated_string();
}
DeprecatedString LanguageID::to_string() const
DeprecatedString LanguageID::to_deprecated_string() const
{
StringBuilder builder;
@ -927,7 +927,7 @@ DeprecatedString LanguageID::to_string() const
return builder.build();
}
DeprecatedString LocaleID::to_string() const
DeprecatedString LocaleID::to_deprecated_string() const
{
StringBuilder builder;
@ -939,7 +939,7 @@ DeprecatedString LocaleID::to_string() const
builder.append(*segment);
};
append_segment(language_id.to_string());
append_segment(language_id.to_deprecated_string());
for (auto const& extension : extensions) {
extension.visit(
@ -955,7 +955,7 @@ DeprecatedString LocaleID::to_string() const
[&](TransformedExtension const& ext) {
builder.append("-t"sv);
if (ext.language.has_value())
append_segment(ext.language->to_string());
append_segment(ext.language->to_deprecated_string());
for (auto const& field : ext.fields) {
append_segment(field.key);
append_segment(field.value);

View file

@ -17,7 +17,7 @@
namespace Locale {
struct LanguageID {
DeprecatedString to_string() const;
DeprecatedString to_deprecated_string() const;
bool operator==(LanguageID const&) const = default;
bool is_root { false };
@ -55,7 +55,7 @@ struct OtherExtension {
using Extension = AK::Variant<LocaleExtension, TransformedExtension, OtherExtension>;
struct LocaleID {
DeprecatedString to_string() const;
DeprecatedString to_deprecated_string() const;
template<typename ExtensionType>
Vector<Extension> remove_extension_type()