RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:48:12 +00:00
Code Issues Activity Actions

Everywhere: Rename to_{string => deprecated_string}() where applicable

Browse source 
This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
This commit is contained in:
Linus Groh 2022-12-06 01:12:49 +00:00 • committed by Andreas Kling
parent 6e19ab2bbc
commit 57dc179b1f
597 changed files with 1973 additions and 1972 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibSQL/Value.cpp
View file

@ -105,7 +105,7 @@ bool Value::is_null() const
return !m_value.has_value();
}
DeprecatedString Value::to_string() const
DeprecatedString Value::to_deprecated_string() const
{
if (is_null())
return "(null)"sv;
@ -346,7 +346,7 @@ int Value::compare(Value const& other) const
return 1;
return m_value->visit(
[&](DeprecatedString const& value) -> int { return value.view().compare(other.to_string()); },
[&](DeprecatedString const& value) -> int { return value.view().compare(other.to_deprecated_string()); },
[&](int value) -> int {
auto casted = other.to_int();
if (!casted.has_value())
@ -407,7 +407,7 @@ bool Value::operator==(Value const& value) const
bool Value::operator==(StringView value) const
{
return to_string() == value;
return to_deprecated_string() == value;
}
bool Value::operator==(int value) const