1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:17:34 +00:00

Everywhere: Rename to_{string => deprecated_string}() where applicable

This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
This commit is contained in:
Linus Groh 2022-12-06 01:12:49 +00:00 committed by Andreas Kling
parent 6e19ab2bbc
commit 57dc179b1f
597 changed files with 1973 additions and 1972 deletions

View file

@ -29,7 +29,7 @@ AvailableSize AvailableSize::make_max_content()
return AvailableSize { Type::MaxContent, INFINITY };
}
DeprecatedString AvailableSize::to_string() const
DeprecatedString AvailableSize::to_deprecated_string() const
{
switch (m_type) {
case Type::Definite:
@ -44,7 +44,7 @@ DeprecatedString AvailableSize::to_string() const
VERIFY_NOT_REACHED();
}
DeprecatedString AvailableSpace::to_string() const
DeprecatedString AvailableSpace::to_deprecated_string() const
{
return DeprecatedString::formatted("{} x {}", width, height);
}

View file

@ -44,7 +44,7 @@ public:
return m_value;
}
DeprecatedString to_string() const;
DeprecatedString to_deprecated_string() const;
private:
AvailableSize(Type type, float);
@ -64,7 +64,7 @@ public:
AvailableSize width;
AvailableSize height;
DeprecatedString to_string() const;
DeprecatedString to_deprecated_string() const;
};
}
@ -73,7 +73,7 @@ template<>
struct AK::Formatter<Web::Layout::AvailableSize> : Formatter<StringView> {
ErrorOr<void> format(FormatBuilder& builder, Web::Layout::AvailableSize const& available_size)
{
return Formatter<StringView>::format(builder, available_size.to_string());
return Formatter<StringView>::format(builder, available_size.to_deprecated_string());
}
};
@ -81,6 +81,6 @@ template<>
struct AK::Formatter<Web::Layout::AvailableSpace> : Formatter<StringView> {
ErrorOr<void> format(FormatBuilder& builder, Web::Layout::AvailableSpace const& available_space)
{
return Formatter<StringView>::format(builder, available_space.to_string());
return Formatter<StringView>::format(builder, available_space.to_deprecated_string());
}
};

View file

@ -160,7 +160,7 @@ OwnPtr<FormattingContext> FormattingContext::create_independent_formatting_conte
// The child box is a block container that doesn't create its own BFC.
// It will be formatted by this BFC.
if (!child_display.is_flow_inside()) {
dbgln("FIXME: Child box doesn't create BFC, but inside is also not flow! display={}", child_display.to_string());
dbgln("FIXME: Child box doesn't create BFC, but inside is also not flow! display={}", child_display.to_deprecated_string());
// HACK: Instead of crashing, create a dummy formatting context that does nothing.
// FIXME: Remove this once it's no longer needed. It currently swallows problem with standalone
// table-related boxes that don't get fixed up by CSS anonymous table box generation.

View file

@ -601,7 +601,7 @@ DeprecatedString Node::debug_description() const
} else {
builder.append("(anonymous)"sv);
}
return builder.to_string();
return builder.to_deprecated_string();
}
CSS::Display Node::display() const

View file

@ -88,7 +88,7 @@ void TextNode::compute_text_for_rendering(bool collapse)
}
}
m_text_for_rendering = builder.to_string();
m_text_for_rendering = builder.to_deprecated_string();
}
TextNode::ChunkIterator::ChunkIterator(StringView text, bool wrap_lines, bool respect_linebreaks, bool is_generated_empty_string)