RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:57:45 +00:00
Code Issues Activity Actions

LibPDF+Tests: Correctly decode text strings without explicit encoding

Browse source
This commit is contained in:
Nico Weber 2023-11-21 21:07:35 -05:00 • committed by Andrew Kaster
parent 8f47acee6a
commit 57e2b5ef59
2 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibPDF/Document.cpp
View file

@ -92,9 +92,7 @@ DeprecatedString Document::text_string_to_utf8(DeprecatedString const& text_stri
return text_string.substring(3);
}
// FIXME: Convert from PDFDocEncoding to UTF-8.
return text_string;
return TextCodec::decoder_for("PDFDocEncoding"sv)->to_utf8(text_string).release_value_but_fixme_should_propagate_errors().to_deprecated_string();
}
PDFErrorOr<NonnullRefPtr<Document>> Document::create(ReadonlyBytes bytes)