RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibWeb: Implement XMLHttpRequest.getResponseHeader()

Browse source 
This lets jQuery's AJAX functionality progress further :^)
This commit is contained in:
Linus Groh 2021-04-03 15:51:15 +02:00 • committed by Andreas Kling
parent 288b90a297
commit 57ead17d54
4 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -102,7 +102,7 @@ static size_t get_function_length(FunctionType& function)
struct Type { struct Type {
String name; String name;
bool nullable { false }; bool nullable { false };
bool is_string() const { return name.is_one_of("DOMString", "USVString", "CSSOMString"); } bool is_string() const { return name.is_one_of("ByteString", "CSSOMString", "DOMString", "USVString"); }
}; };
struct Parameter { struct Parameter {

3
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -229,7 +229,7 @@ DOM::ExceptionOr<void> XMLHttpRequest::send()
// we need to make ResourceLoader give us more detailed updates than just "done" and "error". // we need to make ResourceLoader give us more detailed updates than just "done" and "error".
ResourceLoader::the().load( ResourceLoader::the().load(
request, request,
[weak_this = make_weak_ptr()](auto data, auto&, auto status_code) { [weak_this = make_weak_ptr()](auto data, auto& response_headers, auto status_code) {
if (!weak_this) if (!weak_this)
return; return;
auto& xhr = const_cast<XMLHttpRequest&>(*weak_this); auto& xhr = const_cast<XMLHttpRequest&>(*weak_this);
@ -245,6 +245,7 @@ DOM::ExceptionOr<void> XMLHttpRequest::send()
xhr.m_ready_state = ReadyState::Done; xhr.m_ready_state = ReadyState::Done;
xhr.m_status = status_code.value_or(0); xhr.m_status = status_code.value_or(0);
xhr.m_response_headers = move(response_headers);
xhr.m_send = false; xhr.m_send = false;
xhr.dispatch_event(DOM::Event::create(EventNames::readystatechange)); xhr.dispatch_event(DOM::Event::create(EventNames::readystatechange));
xhr.fire_progress_event(EventNames::load, transmitted, length); xhr.fire_progress_event(EventNames::load, transmitted, length);

3
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.h
View file

@ -76,6 +76,8 @@ public:
DOM::ExceptionOr<void> set_request_header(const String& header, const String& value); DOM::ExceptionOr<void> set_request_header(const String& header, const String& value);
String get_response_header(const String& name) { return m_response_headers.get(name).value_or({}); }
private: private:
virtual void ref_event_target() override { ref(); } virtual void ref_event_target() override { ref(); }
virtual void unref_event_target() override { unref(); } virtual void unref_event_target() override { unref(); }
@ -98,6 +100,7 @@ private:
URL m_url; URL m_url;
HashMap<String, String, CaseInsensitiveStringTraits> m_request_headers; HashMap<String, String, CaseInsensitiveStringTraits> m_request_headers;
HashMap<String, String, CaseInsensitiveStringTraits> m_response_headers;
bool m_synchronous { false }; bool m_synchronous { false };
bool m_upload_complete { false }; bool m_upload_complete { false };

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.idl
View file

@ -16,4 +16,6 @@ interface XMLHttpRequest : XMLHttpRequestEventTarget {
undefined setRequestHeader(DOMString name, DOMString value); undefined setRequestHeader(DOMString name, DOMString value);
undefined send(); undefined send();
ByteString? getResponseHeader(ByteString name);
}; };