From 57f7e6e7755d2da6f455ddeb7855bd5d80175dfa Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sun, 4 Jul 2021 22:51:50 +0100 Subject: [PATCH] LibJS: Remove two unnecessary 'vm.argument(0).value_or(js_undefined())' VM::argument() never returns an empty value. --- Userland/Libraries/LibJS/Runtime/Promise.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Promise.cpp b/Userland/Libraries/LibJS/Runtime/Promise.cpp index ed5be2ed35..81189f3777 100644 --- a/Userland/Libraries/LibJS/Runtime/Promise.cpp +++ b/Userland/Libraries/LibJS/Runtime/Promise.cpp @@ -63,7 +63,7 @@ Promise::ResolvingFunctions Promise::create_resolving_functions() return js_undefined(); } already_resolved.value = true; - auto resolution = vm.argument(0).value_or(js_undefined()); + auto resolution = vm.argument(0); if (resolution.is_object() && &resolution.as_object() == &promise) { dbgln_if(PROMISE_DEBUG, "[Promise @ {} / PromiseResolvingFunction]: Promise can't be resolved with itself, rejecting with error", &promise); auto* self_resolution_error = TypeError::create(global_object, "Cannot resolve promise with itself"); @@ -100,7 +100,7 @@ Promise::ResolvingFunctions Promise::create_resolving_functions() if (already_resolved.value) return js_undefined(); already_resolved.value = true; - auto reason = vm.argument(0).value_or(js_undefined()); + auto reason = vm.argument(0); return promise.reject(reason); });