RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:15:07 +00:00
Code Issues Activity Actions

LibGUI: Remove unnecessary is_enabled() checks in mouse event handlers

Browse source 
We never deliver mouse events to disabled widgets, so there's no need
to check is_enabled() in these event handlers.
This commit is contained in:
Andreas Kling 2020-04-29 19:05:30 +02:00
parent cdbc252190
commit 57fe4d19ac
2 changed files with 19 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibGUI/Slider.cpp
View file

@ -115,8 +115,6 @@ Gfx::Rect Slider::knob_rect() const
void Slider::mousedown_event(MouseEvent& event)
{
if (!is_enabled())
return;
if (event.button() == MouseButton::Left) {
if (knob_rect().contains(event.position())) {
m_dragging = true;
@ -135,8 +133,6 @@ void Slider::mousedown_event(MouseEvent& event)
void Slider::mousemove_event(MouseEvent& event)
{
if (!is_enabled())
return;
set_knob_hovered(knob_rect().contains(event.position()));
if (m_dragging) {
float delta = event.position().primary_offset_for_orientation(orientation()) - m_drag_origin.primary_offset_for_orientation(orientation());
@ -151,8 +147,6 @@ void Slider::mousemove_event(MouseEvent& event)
void Slider::mouseup_event(MouseEvent& event)
{
if (!is_enabled())
return;
if (event.button() == MouseButton::Left) {
m_dragging = false;
return;
@ -163,9 +157,6 @@ void Slider::mouseup_event(MouseEvent& event)
void Slider::mousewheel_event(MouseEvent& event)
{
if (!is_enabled())
return;
if (orientation() == Orientation::Horizontal)
set_value(value() - event.wheel_delta() * m_step);
else