From 582c55a1c8885369841f4621400108629127db7e Mon Sep 17 00:00:00 2001 From: Kemal Zebari Date: Wed, 3 May 2023 09:31:23 -0700 Subject: [PATCH] AK: Have `JsonArray::set()` change values instead of inserting values Resolves #18618. 8134dcc changed `JsonArray::set()` to insert elements at an index instead of changing existing elements in-place. Since no behavior such as `Vector::try_at()` exists yet, it returns nothing. --- AK/JsonArray.h | 2 +- Userland/Libraries/LibGUI/JsonArrayModel.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/AK/JsonArray.h b/AK/JsonArray.h index e292defa48..1154925568 100644 --- a/AK/JsonArray.h +++ b/AK/JsonArray.h @@ -66,7 +66,7 @@ public: void clear() { m_values.clear(); } ErrorOr append(JsonValue value) { return m_values.try_append(move(value)); } - ErrorOr set(size_t index, JsonValue value) { return m_values.try_insert(index, move(value)); } + void set(size_t index, JsonValue value) { m_values.at(index) = move(value); } template typename Builder::OutputType serialized() const; diff --git a/Userland/Libraries/LibGUI/JsonArrayModel.cpp b/Userland/Libraries/LibGUI/JsonArrayModel.cpp index b5baec6a60..c1a5e34932 100644 --- a/Userland/Libraries/LibGUI/JsonArrayModel.cpp +++ b/Userland/Libraries/LibGUI/JsonArrayModel.cpp @@ -97,7 +97,7 @@ ErrorOr JsonArrayModel::set(int row, Vector&& fields) obj.set(field_spec.json_field_name, move(fields.at(i))); } - TRY(m_array.set(row, move(obj))); + m_array.set(row, move(obj)); did_update(); return {};