RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 11:22:45 +00:00
Code Issues Activity Actions

LibWeb: Don't assert when calling navigation properties

Browse source 
The invariants for these property getters are supposed to be checked by
the has_entries_and_events_disabled AO, but we don't have all the
plumbing hooked up between Navigables and Navigation yet.

Add a test to make sure that these methods don't assert when calling
them on a fresh page.
This commit is contained in:
Andrew Kaster 2023-08-25 23:34:27 -06:00 • committed by Sam Atkins
parent aae7905369
commit 587cfa7739
3 changed files with 32 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Text/input/HTML/Navigation-object-properties.html Normal file
View file

@ -0,0 +1,15 @@
<script src="../include.js"></script>
<script>
test(() => {
let n = window.navigation;
// FIXME: Once we set up the interaction between Navigables and Navigation,
// These two should become 1 and [object NavigationHistoryEntry], respectively
println(`entries is empty: ${n.entries().length == 0}`);
println(`currentEntry is null: ${n.currentEntry == null}`);
println(`transition is null: ${n.transition == null}`);
println(`canGoBack: ${n.canGoBack}`);
println(`canGoForward: ${n.canGoForward}`);
});
</script>