RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:14:58 +00:00
Code Issues Activity Actions

LibWeb: Avoid division by zero when computing table width

Browse source 
Previously, a crash could occur when computing the width of a table
with cells that had a percentage width of 0.
This commit is contained in:
Tim Ledbetter 2024-01-20 22:57:45 +00:00 • committed by Andreas Kling
parent 21364711da
commit 58df9c45b9
3 changed files with 33 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/zero_percent_width_nested_table.txt Normal file
View file

@ -0,0 +1,28 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x28 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x12 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 12x12 [BFC] children: not-inline
Box <table> at (8,8) content-size 12x12 table-box [TFC] children: not-inline
Box <tbody> at (8,8) content-size 8x8 table-row-group children: not-inline
Box <tr> at (10,10) content-size 8x8 table-row children: not-inline
BlockContainer <td> at (11,11) content-size 6x6 table-cell [BFC] children: not-inline
TableWrapper <(anonymous)> at (11,11) content-size 6x6 [BFC] children: not-inline
Box <table> at (11,11) content-size 6x6 table-box [TFC] children: not-inline
Box <tbody> at (11,11) content-size 2x2 table-row-group children: not-inline
Box <tr> at (13,13) content-size 2x2 table-row children: not-inline
BlockContainer <td> at (14,14) content-size 0x0 table-cell [BFC] children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x28]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x12]
PaintableWithLines (TableWrapper(anonymous)) [8,8 12x12]
PaintableBox (Box<TABLE>) [8,8 12x12]
PaintableBox (Box<TBODY>) [8,8 8x8] overflow: [8,8 10x10]
PaintableBox (Box<TR>) [10,10 8x8]
PaintableWithLines (BlockContainer<TD>) [10,10 8x8]
PaintableWithLines (TableWrapper(anonymous)) [11,11 6x6]
PaintableBox (Box<TABLE>) [11,11 6x6]
PaintableBox (Box<TBODY>) [11,11 2x2] overflow: [11,11 4x4]
PaintableBox (Box<TR>) [13,13 2x2]
PaintableWithLines (BlockContainer<TD>) [13,13 2x2]

1
Tests/LibWeb/Layout/input/zero_percent_width_nested_table.html Normal file
View file

@ -0,0 +1 @@
<!DOCTYPE html><table><tbody><tr><td><table><tbody><tr><td style="width: 0%">

6
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -492,11 +492,13 @@ void TableFormattingContext::compute_table_width()
// https://www.w3.org/TR/CSS22/tables.html#auto-table-layout
// A percentage value for a column width is relative to the table width. If the table has 'width: auto',
// a percentage represents a constraint on the column's width, which a UA should try to satisfy.
CSSPixels adjusted_used_width = 0;
for (auto& cell : m_cells) {
auto const& cell_width = cell.box->computed_values().width();
if (cell_width.is_percentage()) {
adjusted_used_width = CSSPixels::nearest_value_for(ceil(100 / cell_width.percentage().value() * cell.outer_max_width.to_double())) + undistributable_space;
CSSPixels adjusted_used_width = undistributable_space;
if (cell_width.percentage().value() != 0)
adjusted_used_width += CSSPixels::nearest_value_for(ceil(100 / cell_width.percentage().value() * cell.outer_max_width));
if (width_of_table_containing_block.is_definite())
used_width = min(max(used_width, adjusted_used_width), width_of_table_containing_block.to_px_or_zero());
else