RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:24:57 +00:00
Code Issues Activity Actions

aplay: Determine absolute path before raising the veil

Browse source 
This was a regression introduced in 25d2828e, #18807. In that commit, I
forgot to investigate why the order of operations was so "weird", so I
added a comment this time to prevent future regressions.
This commit is contained in:
Ben Wiederhake 2023-05-19 22:04:13 +02:00 • committed by Jelle Raaijmakers
parent d43d51eedc
commit 58ea30f85a
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Utilities/aplay.cpp
View file

@ -35,8 +35,11 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
args_parser.add_option(show_sample_progress, "Show playback progress in samples", "sample-progress", 's');
args_parser.parse(arguments);
// Note: We must determine the absolute path *before* beginning to raise the veil.
auto absolute_path = TRY(FileSystem::absolute_path(path));
TRY(Core::System::unveil("/tmp/session/%sid/portal/audio", "rw"));
TRY(Core::System::unveil(TRY(FileSystem::absolute_path(path)), "r"sv));
TRY(Core::System::unveil(absolute_path, "r"sv));
TRY(Core::System::unveil(nullptr, nullptr));
Core::EventLoop loop;