RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 10:57:36 +00:00
Code Issues Activity Actions

IPCCompiler: Use string hashes for IPC endpoint magic

Browse source 
This patch removes the IPC endpoint numbers that needed to be specified
in the IPC files.  Since the string hash is a (hopefully) collision free
number that depends on the name of the endpoint, we now use that
instead. :^)
This commit is contained in:
sin-ack 2021-04-25 08:04:17 +02:00 • committed by Andreas Kling
parent f89c60664c
commit 59218007a3
25 changed files with 25 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/HackStudio/LanguageServers/LanguageClient.ipc
View file

@ -1,4 +1,4 @@
endpoint LanguageClient = 8002
endpoint LanguageClient
{
AutoCompleteSuggestions(Vector<GUI::AutocompleteProvider::Entry> suggestions) =|
DeclarationLocation(GUI::AutocompleteProvider::ProjectLocation location) =|

2
Userland/DevTools/HackStudio/LanguageServers/LanguageServer.ipc
View file

@ -1,4 +1,4 @@
endpoint LanguageServer = 8001
endpoint LanguageServer
{
Greet(String project_root) => ()

6
Userland/DevTools/IPCCompiler/main.cpp
View file

@ -164,11 +164,7 @@ int main(int argc, char** argv)
lexer.consume_specific("endpoint");
consume_whitespace();
endpoints.last().name = lexer.consume_while([](char ch) { return !isspace(ch); });
consume_whitespace();
assert_specific('=');
consume_whitespace();
auto magic_string = lexer.consume_while([](char ch) { return !isspace(ch) && ch != '{'; });
endpoints.last().magic = magic_string.to_int().value();
endpoints.last().magic = Traits<String>::hash(endpoints.last().name);
consume_whitespace();
assert_specific('{');
parse_messages();