RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:48:10 +00:00
Code Issues Activity Actions

image: Add --no-output flag to omit output writing

Browse source 
This is useful for timing just decoder performance.

(It'd be nice to add a `-t` flag that prints timings for all
the different phases, but for now just disabling writing is
sufficient for me.)
This commit is contained in:
Nico Weber 2023-05-24 09:00:50 -04:00 • committed by Andreas Kling
parent 32ad77b8c7
commit 5934c4ebfb
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Utilities/image.cpp
View file

@ -24,6 +24,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
StringView out_path; StringView out_path;
args_parser.add_option(out_path, "Path to output image file", "output", 'o', "FILE"); args_parser.add_option(out_path, "Path to output image file", "output", 'o', "FILE");
bool no_output = false;
args_parser.add_option(no_output, "Do not write output (only useful for benchmarking image decoding)", "no-output", {});
int frame_index = 0; int frame_index = 0;
args_parser.add_option(frame_index, "Which frame of a multi-frame input image (0-based)", "frame-index", {}, "INDEX"); args_parser.add_option(frame_index, "Which frame of a multi-frame input image (0-based)", "frame-index", {}, "INDEX");
@ -41,8 +44,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
args_parser.parse(arguments); args_parser.parse(arguments);
if (out_path.is_empty()) { if (out_path.is_empty() ^ no_output) {
warnln("-o is required"); warnln("exactly one of -o or --no-output is required");
return 1; return 1;
} }
@ -81,6 +84,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
if (strip_color_profile) if (strip_color_profile)
icc_data.clear(); icc_data.clear();
if (no_output)
return 0;
auto output_stream = TRY(Core::File::open(out_path, Core::File::OpenMode::Write)); auto output_stream = TRY(Core::File::open(out_path, Core::File::OpenMode::Write));
auto buffered_stream = TRY(Core::OutputBufferedFile::create(move(output_stream))); auto buffered_stream = TRY(Core::OutputBufferedFile::create(move(output_stream)));