RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibWeb: Add support for extended attributes on IDL parameters

Browse source 
Also adds support for [LegacyNullToEmptyString] for parameters.
This commit is contained in:
Luke 2021-05-04 21:38:07 +01:00 • committed by Linus Groh
parent b816000d47
commit 5952bc1ea4
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -90,6 +90,7 @@ struct Parameter {
String name; String name;
bool optional { false }; bool optional { false };
String optional_default_value {}; String optional_default_value {};
HashMap<String, String> extended_attributes;
}; };
struct Function { struct Function {
@ -267,13 +268,16 @@ static OwnPtr<Interface> parse_interface(StringView filename, const StringView&
for (;;) { for (;;) {
if (lexer.next_is(')')) if (lexer.next_is(')'))
break; break;
HashMap<String, String> extended_attributes;
if (lexer.consume_specific('['))
extended_attributes = parse_extended_attributes();
bool optional = lexer.consume_specific("optional"); bool optional = lexer.consume_specific("optional");
if (optional) if (optional)
consume_whitespace(); consume_whitespace();
auto type = parse_type(); auto type = parse_type();
consume_whitespace(); consume_whitespace();
auto name = lexer.consume_until([](auto ch) { return isspace(ch) || ch == ',' || ch == ')' || ch == '='; }); auto name = lexer.consume_until([](auto ch) { return isspace(ch) || ch == ',' || ch == ')' || ch == '='; });
Parameter parameter = { move(type), move(name), optional }; Parameter parameter = { move(type), move(name), optional, {}, extended_attributes };
consume_whitespace(); consume_whitespace();
if (lexer.next_is(')')) { if (lexer.next_is(')')) {
parameters.append(parameter); parameters.append(parameter);
@ -708,8 +712,8 @@ static void generate_arguments(SourceGenerator& generator, const Vector<IDL::Par
arguments_generator.append(R"~~~( arguments_generator.append(R"~~~(
auto arg@argument.index@ = vm.argument(@argument.index@); auto arg@argument.index@ = vm.argument(@argument.index@);
)~~~"); )~~~");
// FIXME: Parameters can have [LegacyNullToEmptyString] attached. bool legacy_null_to_empty_string = parameter.extended_attributes.contains("LegacyNullToEmptyString");
generate_to_cpp(generator, parameter, "arg", String::number(argument_index), parameter.name.to_snakecase(), return_void, false, parameter.optional, parameter.optional_default_value); generate_to_cpp(generator, parameter, "arg", String::number(argument_index), parameter.name.to_snakecase(), return_void, legacy_null_to_empty_string, parameter.optional, parameter.optional_default_value);
++argument_index; ++argument_index;
} }