RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:17:46 +00:00
Code Issues Activity Actions

LibWeb: Allow font-family names to start with -

Browse source 
We achieve this by making properties that accept a custom-ident value
skip the "someone else's vendor prefix" check for values that start with
a `-` character.

This fixes an issue where e.g `font-family: Arial, -apple-system` would
be rejected by the parser completely. We now treat `-apple-system` like
an identifier in such cases.

Also add `valid-types` metadata for the `font-family` property so this
actually works. :^)
This commit is contained in:
Andreas Kling 2023-07-06 13:05:48 +02:00
parent dfdb31f5b0
commit 5955a504e0
4 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/css/font-family-with-dash-prefix.txt Normal file
View file

@ -0,0 +1 @@
serif, -apple-system

9
Tests/LibWeb/Text/input/css/font-family-with-dash-prefix.html Normal file
View file

@ -0,0 +1,9 @@
<script src="../include.js"></script>
<script>
test(() => {
const e = document.createElement("div");
e.style.fontFamily = 'sans-serif';
e.style.fontFamily = 'serif, -apple-system';
println(e.style.fontFamily);
});
</script>