RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:47:45 +00:00
Code Issues Activity Actions

WindowServer: Don't compute title usernames for frameless Windows

Browse source 
This was causing a slight delay when opening ComboBox ListViews.
As an easy first optimization, don't bother computing this at all
for frameless windows and those not type Normal.
This commit is contained in:
thankyouverycool 2022-11-17 09:49:41 -05:00 • committed by Andreas Kling
parent 4ba20f08c7
commit 59e10d5283
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WindowServer/Window.cpp
View file

@ -110,8 +110,10 @@ Window::Window(ConnectionFromClient& client, WindowType window_type, WindowMode
{ {
if (parent_window) if (parent_window)
set_parent_window(*parent_window); set_parent_window(*parent_window);
if (!is_frameless() && type() == WindowType::Normal) {
if (auto title_username_maybe = compute_title_username(&client); !title_username_maybe.is_error()) if (auto title_username_maybe = compute_title_username(&client); !title_username_maybe.is_error())
m_title_username = title_username_maybe.release_value(); m_title_username = title_username_maybe.release_value();
}
WindowManager::the().add_window(*this); WindowManager::the().add_window(*this);
frame().window_was_constructed({}); frame().window_was_constructed({});
} }