diff --git a/Ladybird/BrowserWindow.cpp b/Ladybird/BrowserWindow.cpp index 36ff872b6f..31a8d17679 100644 --- a/Ladybird/BrowserWindow.cpp +++ b/Ladybird/BrowserWindow.cpp @@ -516,15 +516,9 @@ int BrowserWindow::tab_index(Tab* tab) void BrowserWindow::tab_title_changed(int index, QString const& title) { - if (title.isEmpty()) { - m_tabs_container->setTabText(index, "..."); - if (m_tabs_container->currentIndex() == index) - setWindowTitle("Ladybird"); - } else { - m_tabs_container->setTabText(index, title); - if (m_tabs_container->currentIndex() == index) - setWindowTitle(QString("%1 - Ladybird").arg(title)); - } + m_tabs_container->setTabText(index, title); + if (m_tabs_container->currentIndex() == index) + setWindowTitle(QString("%1 - Ladybird").arg(title)); } void BrowserWindow::tab_favicon_changed(int index, QIcon icon) diff --git a/Userland/Applications/Browser/Tab.cpp b/Userland/Applications/Browser/Tab.cpp index 24a4224d70..cf4225e7cc 100644 --- a/Userland/Applications/Browser/Tab.cpp +++ b/Userland/Applications/Browser/Tab.cpp @@ -428,14 +428,10 @@ Tab::Tab(BrowserWindow& window) view().on_link_click(href, "_blank", 0); }; - view().on_title_change = [this](auto& title) { - if (title.is_null()) { - m_history.update_title(url().to_deprecated_string()); - m_title = url().to_deprecated_string(); - } else { - m_history.update_title(title); - m_title = title; - } + view().on_title_change = [this](auto const& title) { + m_history.update_title(title); + m_title = title; + if (on_title_change) on_title_change(m_title); }; diff --git a/Userland/Libraries/LibWebView/WebContentClient.cpp b/Userland/Libraries/LibWebView/WebContentClient.cpp index 10306183fc..0152b726bd 100644 --- a/Userland/Libraries/LibWebView/WebContentClient.cpp +++ b/Userland/Libraries/LibWebView/WebContentClient.cpp @@ -95,7 +95,12 @@ void WebContentClient::did_change_title(DeprecatedString const& title) { dbgln_if(SPAM_DEBUG, "handle: WebContentClient::DidChangeTitle! title={}", title); - if (m_view.on_title_change) + if (!m_view.on_title_change) + return; + + if (title.is_empty()) + m_view.on_title_change(m_view.url().to_deprecated_string()); + else m_view.on_title_change(title); }