From 5a5fa100466c648fe64e10784cb35ca4696e8561 Mon Sep 17 00:00:00 2001 From: Timon Kruiper Date: Thu, 22 Dec 2022 19:06:15 +0100 Subject: [PATCH] Kernel/aarch64: Add FIXME debug messages to PageDirectory These are added to make clear that the current memory situation in the aarch64 kernel is not complete yet. --- Kernel/Arch/aarch64/PageDirectory.cpp | 4 ++-- Kernel/Arch/aarch64/PageDirectory.h | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Kernel/Arch/aarch64/PageDirectory.cpp b/Kernel/Arch/aarch64/PageDirectory.cpp index 99f6335a35..03ee44edf8 100644 --- a/Kernel/Arch/aarch64/PageDirectory.cpp +++ b/Kernel/Arch/aarch64/PageDirectory.cpp @@ -12,7 +12,7 @@ namespace Kernel::Memory { void PageDirectory::register_page_directory(PageDirectory*) { - TODO_AARCH64(); + dbgln("FIXME: PageDirectory: Actually implement registering a page directory!"); } void PageDirectory::deregister_page_directory(PageDirectory*) @@ -28,7 +28,7 @@ LockRefPtr PageDirectory::find_current() void activate_kernel_page_directory(PageDirectory const&) { - // FIXME: Implement this + dbgln("FIXME: PageDirectory: Actually implement activating a kernel page directory!"); } void activate_page_directory(PageDirectory const&, Thread*) diff --git a/Kernel/Arch/aarch64/PageDirectory.h b/Kernel/Arch/aarch64/PageDirectory.h index 5f3da5e2a4..0105e10e06 100644 --- a/Kernel/Arch/aarch64/PageDirectory.h +++ b/Kernel/Arch/aarch64/PageDirectory.h @@ -119,7 +119,12 @@ public: bool is_user_allowed() const { TODO_AARCH64(); } void set_user_allowed(bool) { } - bool is_writable() const { TODO_AARCH64(); } + bool is_writable() const + { + dbgln("FIXME: PageTableEntry: Actually check if the entry is writable!"); + return true; + } + void set_writable(bool) { } bool is_write_through() const { TODO_AARCH64(); }