RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

LibWeb: Fix floating boxes getting stacked on top of each other

Browse source 
This was caused by the freestanding margin_box_rect() using 0 for the
content height instead of the actual content height.
This commit is contained in:
Andreas Kling 2022-02-21 19:38:50 +01:00
parent 89d0cb0ce2
commit 5a770f2eff
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Layout/FormattingState.cpp
View file

@ -40,7 +40,7 @@ void FormattingState::commit()
Gfx::FloatRect margin_box_rect(Box const& box, FormattingState const& state) Gfx::FloatRect margin_box_rect(Box const& box, FormattingState const& state)
{ {
auto const& box_state = state.get(box); auto const& box_state = state.get(box);
auto rect = Gfx::FloatRect { box_state.offset, { box_state.content_width, 0 } }; auto rect = Gfx::FloatRect { box_state.offset, { box_state.content_width, box_state.content_height } };
rect.set_x(rect.x() - box_state.margin_box_left()); rect.set_x(rect.x() - box_state.margin_box_left());
rect.set_width(rect.width() + box_state.margin_box_left() + box_state.margin_box_right()); rect.set_width(rect.width() + box_state.margin_box_left() + box_state.margin_box_right());
rect.set_y(rect.y() - box_state.margin_box_top()); rect.set_y(rect.y() - box_state.margin_box_top());