RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibWeb: Let <br> elements have style

Browse source 
At the very least, we need to respect `<br style="display: none">`
This commit is contained in:
Andreas Kling 2021-09-23 19:46:20 +02:00
parent c113c092ee
commit 5a7d3e3cc1
3 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLBRElement.cpp
View file

@ -1,9 +1,10 @@
/* /*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include <LibWeb/DOM/Document.h>
#include <LibWeb/HTML/HTMLBRElement.h> #include <LibWeb/HTML/HTMLBRElement.h>
#include <LibWeb/Layout/BreakNode.h> #include <LibWeb/Layout/BreakNode.h>
@ -20,7 +21,10 @@ HTMLBRElement::~HTMLBRElement()
RefPtr<Layout::Node> HTMLBRElement::create_layout_node() RefPtr<Layout::Node> HTMLBRElement::create_layout_node()
{ {
return adopt_ref(*new Layout::BreakNode(document(), *this)); auto style = document().style_resolver().resolve_style(*this);
if (style->display() == CSS::Display::None)
return nullptr;
return adopt_ref(*new Layout::BreakNode(document(), *this, move(style)));
} }
} }

4
Userland/Libraries/LibWeb/Layout/BreakNode.cpp
View file

@ -10,8 +10,8 @@
namespace Web::Layout { namespace Web::Layout {
BreakNode::BreakNode(DOM::Document& document, HTML::HTMLBRElement& element) BreakNode::BreakNode(DOM::Document& document, HTML::HTMLBRElement& element, NonnullRefPtr<CSS::StyleProperties> style)
: Layout::NodeWithStyleAndBoxModelMetrics(document, &element, CSS::StyleProperties::create()) : Layout::NodeWithStyleAndBoxModelMetrics(document, &element, move(style))
{ {
set_inline(true); set_inline(true);
} }

2
Userland/Libraries/LibWeb/Layout/BreakNode.h
View file

@ -13,7 +13,7 @@ namespace Web::Layout {
class BreakNode final : public NodeWithStyleAndBoxModelMetrics { class BreakNode final : public NodeWithStyleAndBoxModelMetrics {
public: public:
BreakNode(DOM::Document&, HTML::HTMLBRElement&); BreakNode(DOM::Document&, HTML::HTMLBRElement&, NonnullRefPtr<CSS::StyleProperties>);
virtual ~BreakNode() override; virtual ~BreakNode() override;
const HTML::HTMLBRElement& dom_node() const { return verify_cast<HTML::HTMLBRElement>(*Node::dom_node()); } const HTML::HTMLBRElement& dom_node() const { return verify_cast<HTML::HTMLBRElement>(*Node::dom_node()); }