RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

Kernel: Fix a few typos

Browse source
This commit is contained in:
Nico Weber 2021-09-30 19:48:31 -04:00 • committed by Linus Groh
parent 890d5e45ee
commit 5a951d6258
5 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -39,7 +39,7 @@ enum class NeedsBigProcessLock {
// NOTE: When declaring a new syscall or modifying an existing, please // NOTE: When declaring a new syscall or modifying an existing, please
// ensure that the proper assert is present at the top of the syscall // ensure that the proper assert is present at the top of the syscall
// implementation to both verify and document to any readers if the // implementation to both verify and document to any readers if the
// syscall aquires the big process lock or not. The asserts are: // syscall acquires the big process lock or not. The asserts are:
// - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) // - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this)
// - VERIFY_NO_PROCESS_BIG_LOCK(this) // - VERIFY_NO_PROCESS_BIG_LOCK(this)
// //

2
Kernel/Memory/MemoryManager.cpp
View file

@ -638,7 +638,7 @@ Region* MemoryManager::find_user_region_from_vaddr(AddressSpace& space, VirtualA
void MemoryManager::validate_syscall_preconditions(AddressSpace& space, RegisterState const& regs) void MemoryManager::validate_syscall_preconditions(AddressSpace& space, RegisterState const& regs)
{ {
// We take the space lock once here and then use the no_lock variants // We take the space lock once here and then use the no_lock variants
// to avoid excessive spinlock recursion in this extemely common path. // to avoid excessive spinlock recursion in this extremely common path.
SpinlockLocker lock(space.get_lock()); SpinlockLocker lock(space.get_lock());
auto unlock_and_handle_crash = [&lock, &regs](const char* description, int signal) { auto unlock_and_handle_crash = [&lock, &regs](const char* description, int signal) {

4
Kernel/Net/RTL8168NetworkAdapter.cpp
View file

@ -1082,7 +1082,7 @@ void RTL8168NetworkAdapter::set_phy_speed()
gigabyte_control |= ADVERTISE_1000_FULL; // 1000 mbit full duplex gigabyte_control |= ADVERTISE_1000_FULL; // 1000 mbit full duplex
phy_out(PHY_REG_GBCR, gigabyte_control); phy_out(PHY_REG_GBCR, gigabyte_control);
// restart auto-negotation with set advertisements // restart auto-negotiation with set advertisements
phy_out(PHY_REG_BMCR, BMCR_AUTO_NEGOTIATE | BMCR_RESTART_AUTO_NEGOTIATE); phy_out(PHY_REG_BMCR, BMCR_AUTO_NEGOTIATE | BMCR_RESTART_AUTO_NEGOTIATE);
} }
@ -1216,7 +1216,7 @@ void RTL8168NetworkAdapter::send_raw(ReadonlyBytes payload)
free_descriptor.frame_length = payload.size() & 0x3FFF; free_descriptor.frame_length = payload.size() & 0x3FFF;
free_descriptor.flags = free_descriptor.flags | TXDescriptor::Ownership; free_descriptor.flags = free_descriptor.flags | TXDescriptor::Ownership;
out8(REG_TXSTART, TXSTART_START); // FIXME: this shouldnt be done so often, we should look into doing this using the watchdog timer out8(REG_TXSTART, TXSTART_START); // FIXME: this shouldn't be done so often, we should look into doing this using the watchdog timer
} }
void RTL8168NetworkAdapter::receive() void RTL8168NetworkAdapter::receive()

2
Kernel/Process.cpp
View file

@ -593,7 +593,7 @@ bool Process::dump_perfcore()
auto json_buffer = UserOrKernelBuffer::for_kernel_buffer(json->data()); auto json_buffer = UserOrKernelBuffer::for_kernel_buffer(json->data());
if (description.write(json_buffer, json->size()).is_error()) { if (description.write(json_buffer, json->size()).is_error()) {
return false; return false;
dbgln("Failed to generate perfcore for pid {}: Cound not write to perfcore file.", pid().value()); dbgln("Failed to generate perfcore for pid {}: Could not write to perfcore file.", pid().value());
} }
dbgln("Wrote perfcore for pid {} to {}", pid().value(), description.absolute_path()); dbgln("Wrote perfcore for pid {} to {}", pid().value(), description.absolute_path());

2
Kernel/Syscalls/exit.cpp
View file

@ -13,7 +13,7 @@ namespace Kernel {
void Process::sys$exit(int status) void Process::sys$exit(int status)
{ {
// FIXME: We have callers from kernel which don't aquire the big process lock. // FIXME: We have callers from kernel which don't acquire the big process lock.
if (Thread::current()->previous_mode() == Thread::PreviousMode::UserMode) { if (Thread::current()->previous_mode() == Thread::PreviousMode::UserMode) {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
} }