RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

LibPDF: Dedicated messages for Indexed and Pattern spaces

Browse source 
Makes them easier to interpret in `pdf --debugging-stats` output.
This commit is contained in:
Nico Weber 2023-07-23 22:44:52 -04:00 • committed by Tim Flynn
parent 4bb29e6ac4
commit 5aab31dc40
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibPDF/ColorSpace.cpp
View file

@ -39,8 +39,6 @@ PDFErrorOr<NonnullRefPtr<ColorSpace>> ColorSpace::create(DeprecatedFlyString con
return DeviceRGBColorSpace::the(); return DeviceRGBColorSpace::the();
if (name == CommonNames::DeviceCMYK) if (name == CommonNames::DeviceCMYK)
return DeviceCMYKColorSpace::the(); return DeviceCMYKColorSpace::the();
if (name == CommonNames::Pattern)
return Error::rendering_unsupported_error("Pattern color spaces not yet implemented");
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
@ -59,6 +57,12 @@ PDFErrorOr<NonnullRefPtr<ColorSpace>> ColorSpace::create(Document* document, Non
if (color_space_name == CommonNames::ICCBased) if (color_space_name == CommonNames::ICCBased)
return TRY(ICCBasedColorSpace::create(document, move(parameters))); return TRY(ICCBasedColorSpace::create(document, move(parameters)));
if (color_space_name == CommonNames::Indexed)
return Error::rendering_unsupported_error("Indexed color spaces not yet implemented");
if (color_space_name == CommonNames::Pattern)
return Error::rendering_unsupported_error("Pattern color spaces not yet implemented");
if (color_space_name == CommonNames::Separation) if (color_space_name == CommonNames::Separation)
return TRY(SeparationColorSpace::create(document, move(parameters))); return TRY(SeparationColorSpace::create(document, move(parameters)));

1
Userland/Libraries/LibPDF/CommonNames.h
View file

@ -84,6 +84,7 @@
A(Image) \ A(Image) \
A(ImageMask) \ A(ImageMask) \
A(Index) \ A(Index) \
A(Indexed) \
A(Info) \ A(Info) \
A(JBIG2Decode) \ A(JBIG2Decode) \
A(JPXDecode) \ A(JPXDecode) \