mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 10:07:44 +00:00
LibWeb: Rewrite EventTarget to more closely match the spec
This isn't perfect (especially the global object situation in activate_event_handler), but I believe it's in a much more complete state now :^) This fixes the issue of crashing in prepare_for_ordinary_call with the `i < m_size` crash, as it now uses the IDL callback functions which requires the Environment Settings Object. The environment settings object for the callback is fetched at the time the callback is created, for example, WrapperGenerator gets the incumbent settings object for the callback at the time of wrapping. This allows us to remove passing in ScriptExecutionContext into EventTarget's constructor. With this, we can now drop ScriptExecutionContext.
This commit is contained in:
parent
3bb5c6207f
commit
5aacec65ab
39 changed files with 874 additions and 300 deletions
|
@ -27,14 +27,14 @@ public:
|
|||
using RefCounted::ref;
|
||||
using RefCounted::unref;
|
||||
|
||||
static NonnullRefPtr<AbortSignal> create(Document& document)
|
||||
static NonnullRefPtr<AbortSignal> create()
|
||||
{
|
||||
return adopt_ref(*new AbortSignal(document));
|
||||
return adopt_ref(*new AbortSignal());
|
||||
}
|
||||
|
||||
static NonnullRefPtr<AbortSignal> create_with_global_object(Bindings::WindowObject& window_object)
|
||||
static NonnullRefPtr<AbortSignal> create_with_global_object(Bindings::WindowObject&)
|
||||
{
|
||||
return AbortSignal::create(window_object.impl().associated_document());
|
||||
return AbortSignal::create();
|
||||
}
|
||||
|
||||
virtual ~AbortSignal() override;
|
||||
|
@ -47,8 +47,8 @@ public:
|
|||
|
||||
void signal_abort(JS::Value reason);
|
||||
|
||||
void set_onabort(HTML::EventHandler);
|
||||
HTML::EventHandler onabort();
|
||||
void set_onabort(Optional<Bindings::CallbackType>);
|
||||
Bindings::CallbackType* onabort();
|
||||
|
||||
// https://dom.spec.whatwg.org/#dom-abortsignal-reason
|
||||
JS::Value reason() const { return m_abort_reason; }
|
||||
|
@ -63,7 +63,7 @@ public:
|
|||
virtual JS::Object* create_wrapper(JS::GlobalObject&) override;
|
||||
|
||||
private:
|
||||
AbortSignal(Document& document);
|
||||
AbortSignal();
|
||||
|
||||
// https://dom.spec.whatwg.org/#abortsignal-abort-reason
|
||||
// An AbortSignal object has an associated abort reason, which is a JavaScript value. It is undefined unless specified otherwise.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue