RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

LibWeb: Reset message port receive state before dispatching events

Browse source 
Dispatching events can cause arbitrary JS to run, which could cause the
event loop to be re-entered, or even post another message to the same
message port.
This commit is contained in:
Andrew Kaster 2024-01-05 14:50:01 -07:00 • committed by Andreas Kling
parent 09ce32039f
commit 5ace712282
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/MessagePort.cpp
View file

@ -297,8 +297,11 @@ void MessagePort::read_from_socket()
auto serialize_with_transfer_result = MUST(decoder.decode<SerializedTransferRecord>());
post_message_task_steps(serialize_with_transfer_result);
// Make sure to advance our state machine before dispatching the MessageEvent,
// as dispatching events can run arbitrary JS (and cause us to receive another message!)
m_socket_state = SocketState::Header;
post_message_task_steps(serialize_with_transfer_result);
break;
}
case SocketState::Error: