RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:58:13 +00:00
Code Issues Activity Actions

LibGUI+WindowServer: Provide default placement to windows

Browse source 
This prevents windows from being opened directly on top of eachother,
and provides default behavior for when window position is not specified.

The new behavior is as follows:
- Windows that have been created without a set position are assigned one
  by WindowServer.
- The assigned position is either offset from the last window that is
  still in an assigned position, or a default position if no such window
  is available.
This commit is contained in:
Peter Elliott 2020-07-30 19:52:45 -06:00 • committed by Andreas Kling
parent 586ada7a14
commit 5ae9eee4a3
8 changed files with 62 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Services/WindowServer/ClientConnection.cpp
View file

@ -407,6 +407,10 @@ OwnPtr<Messages::WindowServer::SetWindowRectResponse> ClientConnection::handle(c
dbg() << "ClientConnection: Ignoring SetWindowRect request for fullscreen window";
return nullptr;
}
if (message.rect().location() != window.rect().location()) {
window.set_default_positioned(false);
}
auto normalized_rect = normalize_window_rect(message.rect(), window.type());
window.set_rect(normalized_rect);
window.request_update(normalized_rect);
@ -460,7 +464,12 @@ OwnPtr<Messages::WindowServer::CreateWindowResponse> ClientConnection::handle(co
window->set_has_alpha_channel(message.has_alpha_channel());
window->set_title(message.title());
if (!message.fullscreen()) {
auto normalized_rect = normalize_window_rect(message.rect(), window->type());
auto rect = message.rect();
if (message.auto_position() && window->type() == WindowType::Normal) {
rect = { WindowManager::the().get_recommended_window_position({ 100, 100 }), message.rect().size() };
window->set_default_positioned(true);
}
auto normalized_rect = normalize_window_rect(rect, window->type());
window->set_rect(normalized_rect);
}
if (window->type() == WindowType::Desktop) {