RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:18:12 +00:00
Code Issues Activity Actions

Kernel: Add KResult and KResultOr<T> classes.

Browse source 
The idea here is to combine a potential syscall error code with an arbitrary
type in the case of success. I feel like this will end up much less error
prone than returning some arbitrary type that kinda sorta has bool semantics
(but sometimes not really) and passing the error through an out-param.

This patch only converts a few syscalls to using it. More to come.
This commit is contained in:
Andreas Kling 2019-02-25 20:47:56 +01:00
parent 901b7d5d91
commit 5af4e622b9
12 changed files with 162 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Kernel/Process.cpp
View file

@ -1136,10 +1136,7 @@ int Process::sys$utime(const char* pathname, const utimbuf* buf)
mtime = now;
atime = now;
}
int error;
if (!VFS::the().utime(String(pathname), error, cwd_inode(), atime, mtime))
return error;
return 0;
return VFS::the().utime(String(pathname), cwd_inode(), atime, mtime);
}
int Process::sys$access(const char* pathname, int mode)
@ -1931,10 +1928,7 @@ int Process::sys$mkdir(const char* pathname, mode_t mode)
return -EINVAL;
if (pathname_length >= 255)
return -ENAMETOOLONG;
int error;
if (!VFS::the().mkdir(String(pathname, pathname_length), mode & ~umask(), cwd_inode(), error))
return error;
return 0;
return VFS::the().mkdir(String(pathname, pathname_length), mode & ~umask(), cwd_inode());
}
clock_t Process::sys$times(tms* times)
@ -2143,10 +2137,7 @@ int Process::sys$chmod(const char* pathname, mode_t mode)
{
if (!validate_read_str(pathname))
return -EFAULT;
int error;
if (!VFS::the().chmod(String(pathname), mode, cwd_inode(), error))
return error;
return 0;
return VFS::the().chmod(String(pathname), mode, cwd_inode());
}
void Process::finalize()