From 5b12542d391b1a5b1c6f2438ab5983c50c4c75e2 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Sat, 7 Aug 2021 23:13:16 +0100 Subject: [PATCH] LibJS: Fix Vector => MarkedValueList in calendar_fields() We need to ensure the temporary PrimitiveString cells don't get GC'd. --- Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp index c21cd5f030..cf64642c65 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/Calendar.cpp @@ -97,7 +97,7 @@ Vector calendar_fields(GlobalObject& global_object, Object& calendar, Ve return {}; // 2. Let fieldsArray be ! CreateArrayFromList(fieldNames). - Vector field_names_values; + auto field_names_values = MarkedValueList { vm.heap() }; for (auto& field_name : field_names) field_names_values.append(js_string(vm, field_name)); Value fields_array = Array::create_from(global_object, field_names_values);