RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

LibHTTP: Bump max HTTP header size up to 32KiB

Browse source 
Apparently discord likes to feed us headers as big as 6KiB, so clearly
there are large headers out there in the wild.
For reference, Apache's limit is 8KiB, and IIS's limit is 16KiB (this
limit is not defined by the spec, so nothing can stop a server from
sending massive headers - sadly)
This commit is contained in:
Ali Mohammad Pur 2021-10-04 17:30:45 +03:30 • committed by Andreas Kling
parent 02a369a0a3
commit 5b185d9cb5
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibHTTP/Job.cpp
View file

@ -163,7 +163,8 @@ void Job::on_socket_connected()
if (m_state == State::InHeaders || m_state == State::Trailers) {
if (!can_read_line())
return;
auto line = read_line(PAGE_SIZE);
// There's no max limit defined on headers, but for our sanity, let's limit it to 32K.
auto line = read_line(32 * KiB);
if (line.is_null()) {
if (m_state == State::Trailers) {
// Some servers like to send two ending chunks