mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 10:42:45 +00:00 
			
		
		
		
	LibWeb: Handle immutable state for HTMLInputElement pickers
Which should not be shown if the element is not mutable.
This commit is contained in:
		
							parent
							
								
									7167d6a1c8
								
							
						
					
					
						commit
						5b8be3a08d
					
				
					 2 changed files with 8 additions and 2 deletions
				
			
		|  | @ -179,7 +179,9 @@ static void show_the_picker_if_applicable(HTMLInputElement& element) | ||||||
|     if (!is<HTML::Window>(global_object) || !static_cast<HTML::Window&>(global_object).has_transient_activation()) |     if (!is<HTML::Window>(global_object) || !static_cast<HTML::Window&>(global_object).has_transient_activation()) | ||||||
|         return; |         return; | ||||||
| 
 | 
 | ||||||
|     // FIXME: 2. If element is not mutable, then return.
 |     // 2. If element is not mutable, then return.
 | ||||||
|  |     if (!element.is_mutable()) | ||||||
|  |         return; | ||||||
| 
 | 
 | ||||||
|     // 3. If element's type attribute is in the File Upload state, then run these steps in parallel:
 |     // 3. If element's type attribute is in the File Upload state, then run these steps in parallel:
 | ||||||
|     if (element.type_state() == HTMLInputElement::TypeAttributeState::FileUpload) { |     if (element.type_state() == HTMLInputElement::TypeAttributeState::FileUpload) { | ||||||
|  | @ -219,7 +221,9 @@ WebIDL::ExceptionOr<void> HTMLInputElement::show_picker() | ||||||
| { | { | ||||||
|     // The showPicker() method steps are:
 |     // The showPicker() method steps are:
 | ||||||
| 
 | 
 | ||||||
|     // FIXME: 1. If this is not mutable, then throw an "InvalidStateError" DOMException.
 |     // 1. If this is not mutable, then throw an "InvalidStateError" DOMException.
 | ||||||
|  |     if (!m_is_mutable) | ||||||
|  |         return WebIDL::InvalidStateError::create(realm(), "Element is not mutable"sv); | ||||||
| 
 | 
 | ||||||
|     // 2. If this's relevant settings object's origin is not same origin with this's relevant settings object's top-level origin,
 |     // 2. If this's relevant settings object's origin is not same origin with this's relevant settings object's top-level origin,
 | ||||||
|     // and this's type attribute is not in the File Upload state or Color state, then throw a "SecurityError" DOMException.
 |     // and this's type attribute is not in the File Upload state or Color state, then throw a "SecurityError" DOMException.
 | ||||||
|  |  | ||||||
|  | @ -81,6 +81,8 @@ public: | ||||||
|     bool indeterminate() const { return m_indeterminate; } |     bool indeterminate() const { return m_indeterminate; } | ||||||
|     void set_indeterminate(bool); |     void set_indeterminate(bool); | ||||||
| 
 | 
 | ||||||
|  |     bool is_mutable() const { return m_is_mutable; } | ||||||
|  | 
 | ||||||
|     void did_edit_text_node(Badge<BrowsingContext>); |     void did_edit_text_node(Badge<BrowsingContext>); | ||||||
| 
 | 
 | ||||||
|     JS::GCPtr<FileAPI::FileList> files(); |     JS::GCPtr<FileAPI::FileList> files(); | ||||||
|  |  | ||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Shannon Booth
						Shannon Booth