RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

LibPDF: Add more spec comments to parse_charset()

Browse source
This commit is contained in:
Nico Weber 2023-10-13 10:31:52 -04:00 • committed by Jelle Raaijmakers
parent 49275c4b17
commit 5b915fb15c
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibPDF/Fonts/CFF.cpp
View file

@ -623,12 +623,15 @@ PDFErrorOr<Vector<DeprecatedFlyString>> CFF::parse_charset(Reader&& reader, size
Vector<DeprecatedFlyString> names; Vector<DeprecatedFlyString> names;
auto format = TRY(reader.try_read<Card8>()); auto format = TRY(reader.try_read<Card8>());
if (format == 0) { if (format == 0) {
// CFF spec, "Table 17 Format 0"
for (u8 i = 0; i < glyph_count - 1; i++) { for (u8 i = 0; i < glyph_count - 1; i++) {
SID sid = TRY(reader.try_read<BigEndian<SID>>()); SID sid = TRY(reader.try_read<BigEndian<SID>>());
TRY(names.try_append(resolve_sid(sid, strings))); TRY(names.try_append(resolve_sid(sid, strings)));
} }
} else if (format == 1) { } else if (format == 1) {
// CFF spec, "Table 18 Format 1"
while (names.size() < glyph_count - 1) { while (names.size() < glyph_count - 1) {
// CFF spec, "Table 19 Range1 Format (Charset)"
auto first_sid = TRY(reader.try_read<BigEndian<SID>>()); auto first_sid = TRY(reader.try_read<BigEndian<SID>>());
int left = TRY(reader.try_read<Card8>()); int left = TRY(reader.try_read<Card8>());
for (SID sid = first_sid; left >= 0; left--, sid++) for (SID sid = first_sid; left >= 0; left--, sid++)