RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

FileSystemPath: Add a has_extension() helper.

Browse source 
This code:

    if (path.string().to_lowercase().ends_with(".foo"))

Can now be written as:

    if (path.has_extension(".foo"))
This commit is contained in:
Andreas Kling 2019-05-26 22:33:30 +02:00
parent 6ac8aab941
commit 5ba2dba392
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
AK/FileSystemPath.cpp
View file

@ -45,5 +45,11 @@ bool FileSystemPath::canonicalize(bool resolve_symbolic_links)
return true; return true;
} }
bool FileSystemPath::has_extension(StringView extension) const
{
// FIXME: This is inefficient, expand StringView with enough functionality that we don't need to copy strings here.
String extension_string = extension;
return m_string.to_lowercase().ends_with(extension_string.to_lowercase());
} }
}

2
AK/FileSystemPath.h
View file

@ -16,6 +16,8 @@ public:
const Vector<String>& parts() const { return m_parts; } const Vector<String>& parts() const { return m_parts; }
bool has_extension(StringView) const;
private: private:
bool canonicalize(bool resolve_symbolic_links = false); bool canonicalize(bool resolve_symbolic_links = false);