RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

AK: Make encode_base64 take a ByteBuffer and return a String

Browse source 
That makes the interface symmetric with decode_base64 and it's
what all current callers want (except for one, which is buggy).
This commit is contained in:
Nico Weber 2020-07-22 11:39:07 -04:00 • committed by Andreas Kling
parent 9e32ad6c99
commit 5ba8aba197
5 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -267,8 +267,8 @@ JS_DEFINE_NATIVE_FUNCTION(WindowObject::btoa)
if (interpreter.exception())
return {};
// FIXME: This should convert string to a non-UTF-8 byte string first.
auto encoded = encode_base64(StringView(string));
return JS::js_string(interpreter, String::copy(encoded));
auto encoded = encode_base64(ByteBuffer::wrap(string.characters(), string.length()));
return JS::js_string(interpreter, move(encoded));
}
JS_DEFINE_NATIVE_GETTER(WindowObject::document_getter)