RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:28:12 +00:00
Code Issues Activity Actions

LibWeb: Null-check layout node before dereferencing in HTMLVideoElement

Browse source 
DOM elements don't always have a corresponding layout node. This fixes a
crash soon after loading the Steam store.
This commit is contained in:
Andreas Kling 2023-05-17 20:54:11 +02:00 • committed by Tim Flynn
parent fb722e69f3
commit 5bb6e2c80c
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/HTML/HTMLVideoElement.cpp
View file

@ -109,7 +109,8 @@ void HTMLVideoElement::set_video_track(JS::GCPtr<HTML::VideoTrack> video_track)
void HTMLVideoElement::set_current_frame(Badge<VideoTrack>, RefPtr<Gfx::Bitmap> frame, double position) void HTMLVideoElement::set_current_frame(Badge<VideoTrack>, RefPtr<Gfx::Bitmap> frame, double position)
{ {
m_current_frame = { move(frame), position }; m_current_frame = { move(frame), position };
layout_node()->set_needs_display(); if (layout_node())
layout_node()->set_needs_display();
} }
void HTMLVideoElement::on_playing() void HTMLVideoElement::on_playing()