RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

LanguageServers/Cpp: Add 'FindDeclaration' capability

Browse source 
The C++ LanguageServer can now find the matching declaration for
variable names, function calls, struct/class types and properties.

When clicking on one of the above with Ctrl pressed, HackStudio will
ask the language server to find a matching declaration, and navigate
to the result in the Editor. :^)
This commit is contained in:
Itamar 2021-02-20 12:27:39 +02:00 • committed by Andreas Kling
parent d3ff82ba80
commit 5bc82c0185
12 changed files with 150 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/DevTools/HackStudio/LanguageClient.cpp
View file

@ -40,6 +40,14 @@ void ServerConnection::handle(const Messages::LanguageClient::AutoCompleteSugges
}
m_language_client->provide_autocomplete_suggestions(message.suggestions());
}
void ServerConnection::handle(const Messages::LanguageClient::DeclarationLocation& message)
{
if (!m_language_client) {
dbgln("Language Server connection has no attached language client");
return;
}
m_language_client->declaration_found(message.file_name(), message.line(), message.column());
}
void ServerConnection::die()
{
@ -87,8 +95,6 @@ void LanguageClient::request_autocomplete(const String& path, size_t cursor_line
void LanguageClient::provide_autocomplete_suggestions(const Vector<GUI::AutocompleteProvider::Entry>& suggestions)
{
if (!m_server_connection)
return;
if (on_autocomplete_suggestions)
on_autocomplete_suggestions(suggestions);
@ -147,4 +153,22 @@ void ServerConnection::remove_instance_for_project(const String& project_path)
s_instances_for_projects.remove(key);
}
void LanguageClient::search_declaration(const String& path, size_t line, size_t column)
{
if (!m_server_connection)
return;
set_active_client();
m_server_connection->post_message(Messages::LanguageServer::FindDeclaration(path, line, column));
}
void LanguageClient::declaration_found(const String& file, size_t line, size_t column)
{
if (!on_declaration_found) {
dbgln("on_declaration_found callback is not set");
return;
}
dbgln("calling on_declaration_found");
on_declaration_found(file, line, column);
}
}