RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:57:44 +00:00
Code Issues Activity Actions

LibWebView+Ladybird: Move text selection to ViewImplementation

Browse source
This commit is contained in:
Linus Groh 2023-01-12 20:42:42 +00:00 • committed by Andreas Kling
parent 8c11a2c253
commit 5bf5697f16
6 changed files with 13 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Ladybird/WebContentView.cpp
View file

@ -1043,13 +1043,3 @@ void WebContentView::notify_server_did_get_accessibility_tree(DeprecatedString c
{ {
dbgln("TODO: support accessibility tree in Ladybird"); dbgln("TODO: support accessibility tree in Ladybird");
} }
DeprecatedString WebContentView::selected_text()
{
return client().get_selected_text();
}
void WebContentView::select_all()
{
client().async_select_all();
}

3
Ladybird/WebContentView.h
View file

@ -97,9 +97,6 @@ public:
void set_preferred_color_scheme(Web::CSS::PreferredColorScheme); void set_preferred_color_scheme(Web::CSS::PreferredColorScheme);
DeprecatedString selected_text();
void select_all();
virtual void notify_server_did_layout(Badge<WebContentClient>, Gfx::IntSize content_size) override; virtual void notify_server_did_layout(Badge<WebContentClient>, Gfx::IntSize content_size) override;
virtual void notify_server_did_paint(Badge<WebContentClient>, i32 bitmap_id) override; virtual void notify_server_did_paint(Badge<WebContentClient>, i32 bitmap_id) override;
virtual void notify_server_did_invalidate_content_rect(Badge<WebContentClient>, Gfx::IntRect const&) override; virtual void notify_server_did_invalidate_content_rect(Badge<WebContentClient>, Gfx::IntRect const&) override;

10
Userland/Libraries/LibWebView/OutOfProcessWebView.cpp
View file

@ -552,16 +552,6 @@ void OutOfProcessWebView::js_console_request_messages(i32 start_index)
client().async_js_console_request_messages(start_index); client().async_js_console_request_messages(start_index);
} }
DeprecatedString OutOfProcessWebView::selected_text()
{
return client().get_selected_text();
}
void OutOfProcessWebView::select_all()
{
client().async_select_all();
}
DeprecatedString OutOfProcessWebView::dump_layout_tree() DeprecatedString OutOfProcessWebView::dump_layout_tree()
{ {
return client().dump_layout_tree(); return client().dump_layout_tree();

3
Userland/Libraries/LibWebView/OutOfProcessWebView.h
View file

@ -36,9 +36,6 @@ public:
void js_console_input(DeprecatedString const& js_source); void js_console_input(DeprecatedString const& js_source);
void js_console_request_messages(i32 start_index); void js_console_request_messages(i32 start_index);
DeprecatedString selected_text();
void select_all();
DeprecatedString dump_layout_tree(); DeprecatedString dump_layout_tree();
OrderedHashMap<DeprecatedString, DeprecatedString> get_local_storage_entries(); OrderedHashMap<DeprecatedString, DeprecatedString> get_local_storage_entries();

10
Userland/Libraries/LibWebView/ViewImplementation.cpp
View file

@ -61,6 +61,16 @@ void ViewImplementation::reset_zoom()
update_zoom(); update_zoom();
} }
DeprecatedString ViewImplementation::selected_text()
{
return client().get_selected_text();
}
void ViewImplementation::select_all()
{
client().async_select_all();
}
void ViewImplementation::get_source() void ViewImplementation::get_source()
{ {
client().async_get_source(); client().async_get_source();

3
Userland/Libraries/LibWebView/ViewImplementation.h
View file

@ -38,6 +38,9 @@ public:
void zoom_out(); void zoom_out();
void reset_zoom(); void reset_zoom();
DeprecatedString selected_text();
void select_all();
void get_source(); void get_source();
void inspect_dom_tree(); void inspect_dom_tree();