RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:47:45 +00:00
Code Issues Activity Actions

LibELF + LibDebug: Reduce allocations during symbolification

Browse source 
Avoid promotion of static strings to AK::String, instead use
AK::StringView and operator ""sv, to force string view's instead
which avoids allocation of String. This code path isn't hot enough
that it makes a huge difference, but every bit counts.
This commit is contained in:
Brian Gianforcaro 2021-05-30 23:44:02 -07:00 • committed by Ali Mohammad Pur
parent 35a97884aa
commit 5bfba3f789
5 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibDebug/DebugInfo.cpp
View file

@ -17,7 +17,7 @@ namespace Debug {
DebugInfo::DebugInfo(NonnullOwnPtr<const ELF::Image> elf, String source_root, FlatPtr base_address)
: m_elf(move(elf))
, m_source_root(source_root)
, m_source_root(move(source_root))
, m_base_address(base_address)
, m_dwarf_info(*m_elf)
{
@ -78,7 +78,7 @@ void DebugInfo::parse_scopes_impl(const Dwarf::DIE& die)
void DebugInfo::prepare_lines()
{
auto section = elf().lookup_section(".debug_line");
auto section = elf().lookup_section(".debug_line"sv);
if (!section.has_value())
return;

10
Userland/Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -13,15 +13,15 @@ namespace Debug::Dwarf {
DwarfInfo::DwarfInfo(const ELF::Image& elf)
: m_elf(elf)
{
m_debug_info_data = section_data(".debug_info");
m_abbreviation_data = section_data(".debug_abbrev");
m_debug_strings_data = section_data(".debug_str");
m_debug_line_strings_data = section_data(".debug_line_str");
m_debug_info_data = section_data(".debug_info"sv);
m_abbreviation_data = section_data(".debug_abbrev"sv);
m_debug_strings_data = section_data(".debug_str"sv);
m_debug_line_strings_data = section_data(".debug_line_str"sv);
populate_compilation_units();
}
ReadonlyBytes DwarfInfo::section_data(const String& section_name) const
ReadonlyBytes DwarfInfo::section_data(const StringView& section_name) const
{
auto section = m_elf.lookup_section(section_name);
if (!section.has_value())

2
Userland/Libraries/LibDebug/Dwarf/DwarfInfo.h
View file

@ -60,7 +60,7 @@ public:
private:
void populate_compilation_units();
ReadonlyBytes section_data(const String& section_name) const;
ReadonlyBytes section_data(const StringView& section_name) const;
const ELF::Image& m_elf;
ReadonlyBytes m_debug_info_data;