RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 18:05:07 +00:00
Code Issues Activity Actions

LibGfx: Prefer using Gfx::Bitmap::load_from_file instead of load_png()

Browse source 
Code that just wants to open a Gfx::Bitmap from a file should not be
calling the PNG codec directly.
This commit is contained in:
Andreas Kling 2020-02-06 13:39:17 +01:00
parent f8b00aa290
commit 5c06c32df4
31 changed files with 48 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibGUI/GFilePicker.cpp
View file

@ -26,7 +26,6 @@
#include <AK/FileSystemPath.h>
#include <AK/Function.h>
#include <LibGfx/PNGLoader.h>
#include <LibGUI/GAction.h>
#include <LibGUI/GBoxLayout.h>
#include <LibGUI/GButton.h>
@ -254,7 +253,7 @@ FilePicker::~FilePicker()
void FilePicker::set_preview(const FileSystemPath& path)
{
if (path.has_extension(".png")) {
auto bitmap = Gfx::load_png(path.string());
auto bitmap = Gfx::Bitmap::load_from_file(path.string());
if (!bitmap) {
clear_preview();
return;