From 5c21f963ff7a11ec160707d1a6f6831af38a3af0 Mon Sep 17 00:00:00 2001 From: Lenny Maiorani Date: Fri, 4 Mar 2022 14:08:53 -0700 Subject: [PATCH] Libraries: Use default constructors/destructors in LibX86 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler." --- Userland/Libraries/LibCoredump/Reader.h | 1 + Userland/Libraries/LibX86/Instruction.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibCoredump/Reader.h b/Userland/Libraries/LibCoredump/Reader.h index 5fef5b1a88..536ecfb009 100644 --- a/Userland/Libraries/LibCoredump/Reader.h +++ b/Userland/Libraries/LibCoredump/Reader.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ diff --git a/Userland/Libraries/LibX86/Instruction.h b/Userland/Libraries/LibX86/Instruction.h index 1fe247e486..f9b920af58 100644 --- a/Userland/Libraries/LibX86/Instruction.h +++ b/Userland/Libraries/LibX86/Instruction.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -489,7 +490,7 @@ class Instruction { public: template static Instruction from_stream(InstructionStreamType&, bool o32, bool a32); - ~Instruction() { } + ~Instruction() = default; ALWAYS_INLINE MemoryOrRegisterReference& modrm() const { return m_modrm; }