diff --git a/Applications/Browser/Tab.cpp b/Applications/Browser/Tab.cpp index d0a98ef19f..4deea4bdb2 100644 --- a/Applications/Browser/Tab.cpp +++ b/Applications/Browser/Tab.cpp @@ -133,13 +133,13 @@ Tab::Tab() update_bookmark_button(url.to_string()); }; - m_html_widget->on_link_click = [this](auto& href, auto& target) { + m_html_widget->on_link_click = [this](auto& href, auto& target, unsigned modifiers) { if (href.starts_with("#")) { auto anchor = href.substring_view(1, href.length() - 1); m_html_widget->scroll_to_anchor(anchor); } else { auto url = m_html_widget->document()->complete_url(href); - if (target == "_blank") + if (target == "_blank" || modifiers == Mod_Ctrl) on_tab_open_request(url); else m_html_widget->load(url); diff --git a/Applications/Help/main.cpp b/Applications/Help/main.cpp index 26c69255b5..81767dee17 100644 --- a/Applications/Help/main.cpp +++ b/Applications/Help/main.cpp @@ -151,7 +151,7 @@ int main(int argc, char* argv[]) open_page(path); }; - html_view.on_link_click = [&](const String& href, auto&) { + html_view.on_link_click = [&](const String& href, auto&, unsigned) { char* current_path = strdup(history.current().characters()); char* dir_path = dirname(current_path); char* path = realpath(String::format("%s/%s", dir_path, href.characters()).characters(), nullptr); diff --git a/Libraries/LibWeb/HtmlView.cpp b/Libraries/LibWeb/HtmlView.cpp index d4aa3f09f0..8036d136bd 100644 --- a/Libraries/LibWeb/HtmlView.cpp +++ b/Libraries/LibWeb/HtmlView.cpp @@ -238,7 +238,7 @@ void HtmlView::mousedown_event(GUI::MouseEvent& event) run_javascript_url(link->href()); } else { if (on_link_click) - on_link_click(link->href(), link->target()); + on_link_click(link->href(), link->target(), event.modifiers()); } } else { if (event.button() == GUI::MouseButton::Left) { diff --git a/Libraries/LibWeb/HtmlView.h b/Libraries/LibWeb/HtmlView.h index ddf830e3a8..51de2194b3 100644 --- a/Libraries/LibWeb/HtmlView.h +++ b/Libraries/LibWeb/HtmlView.h @@ -57,7 +57,7 @@ public: void set_should_show_line_box_borders(bool value) { m_should_show_line_box_borders = value; } - Function on_link_click; + Function on_link_click; Function on_link_hover; Function on_title_change; Function on_load_start;