RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

Shell: Stop making shell history files world-readable

Browse source 
\0 pointed out that it's pretty bad to have world-readable .history
files, especially for root's shell!
This commit is contained in:
Andreas Kling 2020-03-30 12:09:26 +02:00
parent 0df15823b5
commit 5c37570dfc
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Shell/main.cpp
View file

@ -978,8 +978,8 @@ void load_history()
void save_history() void save_history()
{ {
auto history_file = Core::File::construct(get_history_path()); auto history_file = Core::File::open(get_history_path(), Core::IODevice::WriteOnly, 0600);
if (!history_file->open(Core::IODevice::WriteOnly)) if (!history_file)
return; return;
for (const auto& line : editor.history()) { for (const auto& line : editor.history()) {
history_file->write(line); history_file->write(line);