From 5c8405c455d8ef44fa8ac153a958dd3ead84ec08 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= <filmroellchen@serenityos.org>
Date: Mon, 26 Jun 2023 21:07:58 +0200
Subject: [PATCH] ClipboardHistory: Use i32 config change listener

Fixes a FIXME.
---
 .../Applets/ClipboardHistory/ClipboardHistoryModel.cpp     | 7 +------
 Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h  | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp b/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp
index 5b6725d007..0b4c352895 100644
--- a/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp
+++ b/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp
@@ -155,17 +155,12 @@ void ClipboardHistoryModel::clear()
     invalidate_model_and_file(true).release_value_but_fixme_should_propagate_errors();
 }
 
-void ClipboardHistoryModel::config_string_did_change(StringView domain, StringView group, StringView key, StringView value_string)
+void ClipboardHistoryModel::config_i32_did_change(StringView domain, StringView group, StringView key, i32 value)
 {
     if (domain != "ClipboardHistory" || group != "ClipboardHistory")
         return;
 
-    // FIXME: Once we can get notified for `i32` changes, we can use that instead of this hack.
     if (key == "NumHistoryItems") {
-        auto value_or_error = value_string.to_int();
-        if (!value_or_error.has_value())
-            return;
-        auto value = value_or_error.value();
         if (value < (int)m_history_items.size()) {
             m_history_items.remove(value, m_history_items.size() - value);
             invalidate_model_and_file(false).release_value_but_fixme_should_propagate_errors();
diff --git a/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h b/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h
index 029f624aeb..bb9ea56850 100644
--- a/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h
+++ b/Userland/Applets/ClipboardHistory/ClipboardHistoryModel.h
@@ -53,7 +53,7 @@ public:
     virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override;
 
     // ^Config::Listener
-    virtual void config_string_did_change(StringView domain, StringView group, StringView key, StringView value) override;
+    virtual void config_i32_did_change(StringView domain, StringView group, StringView key, i32 value) override;
 
 private:
     ClipboardHistoryModel();