RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 01:47:36 +00:00
Code Issues Activity Actions

LibJS: Simplify the way we stringify bytecode instructions

Browse source 
For instructions that only have a single operand, omit the operand
name since it's implied anyway.
This commit is contained in:
Andreas Kling 2021-06-09 11:06:11 +02:00
parent aa63fe20a5
commit 5c98f979c6
1 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -79,7 +79,7 @@ static Value typed_equals(GlobalObject&, Value src1, Value src2)
} \ } \
String OpTitleCase::to_string() const \ String OpTitleCase::to_string() const \
{ \ { \
return String::formatted(#OpTitleCase " lhs:{}", m_lhs_reg); \ return String::formatted(#OpTitleCase " {}", m_lhs_reg); \
} }
JS_ENUMERATE_COMMON_BINARY_OPS(JS_DEFINE_COMMON_BINARY_OP) JS_ENUMERATE_COMMON_BINARY_OPS(JS_DEFINE_COMMON_BINARY_OP)
@ -233,22 +233,22 @@ void Return::execute(Bytecode::Interpreter& interpreter) const
String Load::to_string() const String Load::to_string() const
{ {
return String::formatted("Load src:{}", m_src); return String::formatted("Load {}", m_src);
} }
String LoadImmediate::to_string() const String LoadImmediate::to_string() const
{ {
return String::formatted("LoadImmediate value:{}", m_value); return String::formatted("LoadImmediate {}", m_value);
} }
String Store::to_string() const String Store::to_string() const
{ {
return String::formatted("Store dst:{}", m_dst); return String::formatted("Store {}", m_dst);
} }
String NewBigInt::to_string() const String NewBigInt::to_string() const
{ {
return String::formatted("NewBigInt bigint:\"{}\"", m_bigint.to_base10()); return String::formatted("NewBigInt \"{}\"", m_bigint.to_base10());
} }
String NewArray::to_string() const String NewArray::to_string() const
@ -256,7 +256,7 @@ String NewArray::to_string() const
StringBuilder builder; StringBuilder builder;
builder.append("NewArray"); builder.append("NewArray");
if (m_element_count != 0) { if (m_element_count != 0) {
builder.append(", elements:["); builder.append(" [");
for (size_t i = 0; i < m_element_count; ++i) { for (size_t i = 0; i < m_element_count; ++i) {
builder.appendff("{}", m_elements[i]); builder.appendff("{}", m_elements[i]);
if (i != m_element_count - 1) if (i != m_element_count - 1)
@ -269,7 +269,7 @@ String NewArray::to_string() const
String NewString::to_string() const String NewString::to_string() const
{ {
return String::formatted("NewString string:\"{}\"", m_string); return String::formatted("NewString \"{}\"", m_string);
} }
String NewObject::to_string() const String NewObject::to_string() const
@ -279,17 +279,17 @@ String NewObject::to_string() const
String ConcatString::to_string() const String ConcatString::to_string() const
{ {
return String::formatted("ConcatString lhs:{}", m_lhs); return String::formatted("ConcatString {}", m_lhs);
} }
String GetVariable::to_string() const String GetVariable::to_string() const
{ {
return String::formatted("GetVariable identifier:{}", m_identifier); return String::formatted("GetVariable {}", m_identifier);
} }
String SetVariable::to_string() const String SetVariable::to_string() const
{ {
return String::formatted("SetVariable identifier:{}", m_identifier); return String::formatted("SetVariable {}", m_identifier);
} }
String PutById::to_string() const String PutById::to_string() const
@ -299,7 +299,7 @@ String PutById::to_string() const
String GetById::to_string() const String GetById::to_string() const
{ {
return String::formatted("GetById property:{}", m_property); return String::formatted("GetById {}", m_property);
} }
String Jump::to_string() const String Jump::to_string() const