RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:37:34 +00:00
Code Issues Activity Actions

LibWeb: Rename element_before() => element_immediately_above()

Browse source 
This matches the spec terminology around the "stack of open elements".
This commit is contained in:
Andreas Kling 2022-02-14 22:24:10 +01:00
parent 6fe333607d
commit 5cdbea4ae0
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -551,7 +551,7 @@ HTMLParser::AdjustedInsertionLocation HTMLParser::find_appropriate_place_for_ins
adjusted_insertion_location = { last_table.element->parent_node(), last_table.element };
} else {
// 6. Let previous element be the element immediately above last table in the stack of open elements.
auto previous_element = m_stack_of_open_elements.element_before(*last_table.element);
auto previous_element = m_stack_of_open_elements.element_immediately_above(*last_table.element);
// 7. Let adjusted insertion location be inside previous element, after its last child (if any).
adjusted_insertion_location = { previous_element, nullptr };

2
Userland/Libraries/LibWeb/HTML/Parser/StackOfOpenElements.cpp
View file

@ -123,7 +123,7 @@ StackOfOpenElements::LastElementResult StackOfOpenElements::last_element_with_ta
return { nullptr, -1 };
}
DOM::Element* StackOfOpenElements::element_before(const DOM::Element& target)
DOM::Element* StackOfOpenElements::element_immediately_above(DOM::Element const& target)
{
bool found_target = false;
for (ssize_t i = m_elements.size() - 1; i >= 0; --i) {

2
Userland/Libraries/LibWeb/HTML/Parser/StackOfOpenElements.h
View file

@ -50,7 +50,7 @@ public:
ssize_t index;
};
LastElementResult last_element_with_tag_name(const FlyString&);
DOM::Element* element_before(const DOM::Element&);
DOM::Element* element_immediately_above(DOM::Element const&);
private:
bool has_in_scope_impl(const FlyString& tag_name, const Vector<FlyString>&) const;