RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:18:12 +00:00
Code Issues Activity Actions

WindowServer: Add Menu::is_open() to improve readability

Browse source 
"menu.is_open()" instead of "MenuManager::the().is_open(menu)"
This commit is contained in:
Andreas Kling 2021-05-17 22:01:05 +02:00
parent dfb2178519
commit 5d0c3bd564
4 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Services/WindowServer/WindowFrame.cpp
View file

@ -293,9 +293,10 @@ void WindowFrame::paint_menubar(Gfx::Painter& painter)
m_window.menubar()->for_each_menu([&](Menu& menu) {
auto text_rect = menu.rect_in_window_menubar();
Color text_color = palette.window_text();
if (MenuManager::the().is_open(menu))
auto is_open = menu.is_open();
if (is_open)
text_rect.translate_by(1, 1);
bool paint_as_pressed = MenuManager::the().is_open(menu);
bool paint_as_pressed = is_open;
bool paint_as_hovered = !paint_as_pressed && &menu == MenuManager::the().hovered_menu();
if (paint_as_pressed || paint_as_hovered) {
Gfx::StylePainter::paint_button(painter, menu.rect_in_window_menubar(), palette, Gfx::ButtonStyle::Coolbar, paint_as_pressed, paint_as_hovered);