RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:18:11 +00:00
Code Issues Activity Actions

Everywhere: Rename ASSERT => VERIFY

Browse source 
(...and ASSERT_NOT_REACHED => VERIFY_NOT_REACHED)

Since all of these checks are done in release builds as well,
let's rename them to VERIFY to prevent confusion, as everyone is
used to assertions being compiled out in release.

We can introduce a new ASSERT macro that is specifically for debug
checks, but I'm doing this wholesale conversion first since we've
accumulated thousands of these already, and it's not immediately
obvious which ones are suitable for ASSERT.
This commit is contained in:
Andreas Kling 2021-02-23 20:42:32 +01:00
parent b33a6a443e
commit 5d180d1f99
725 changed files with 3448 additions and 3448 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Time/APICTimer.cpp
View file

@ -54,7 +54,7 @@ UNMAP_AFTER_INIT APICTimer::APICTimer(u8 interrupt_number, Function<void(const R
UNMAP_AFTER_INIT bool APICTimer::calibrate(HardwareTimerBase& calibration_source)
{
ASSERT_INTERRUPTS_DISABLED();
VERIFY_INTERRUPTS_DISABLED();
klog() << "APICTimer: Using " << calibration_source.model() << " as calibration source";
@ -96,7 +96,7 @@ UNMAP_AFTER_INIT bool APICTimer::calibrate(HardwareTimerBase& calibration_source
// tick count from the APIC timer
auto original_callback = set_callback([&](const RegisterState&) {
klog() << "APICTimer: Timer fired during calibration!";
ASSERT_NOT_REACHED(); // TODO: How should we handle this?
VERIFY_NOT_REACHED(); // TODO: How should we handle this?
});
apic.setup_local_timer(0xffffffff, APIC::TimerMode::Periodic, true);
@ -153,12 +153,12 @@ size_t APICTimer::ticks_per_second() const
void APICTimer::set_periodic()
{
// FIXME: Implement it...
ASSERT_NOT_REACHED();
VERIFY_NOT_REACHED();
}
void APICTimer::set_non_periodic()
{
// FIXME: Implement it...
ASSERT_NOT_REACHED();
VERIFY_NOT_REACHED();
}
void APICTimer::reset_to_default_ticks_per_second()