RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 04:44:58 +00:00
Code Issues Activity Actions

LibWeb: Return DOMException instead of crashing when setting attributes

Browse source
This commit is contained in:
PrestonLTaylor 2023-05-25 20:37:57 +01:00 • committed by Andreas Kling
parent 6891676fce
commit 5d3b7a5ecc
24 changed files with 57 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -168,9 +168,9 @@ unsigned HTMLImageElement::width() const
return 0;
}
void HTMLImageElement::set_width(unsigned width)
WebIDL::ExceptionOr<void> HTMLImageElement::set_width(unsigned width)
{
MUST(set_attribute(HTML::AttributeNames::width, DeprecatedString::number(width)));
return set_attribute(HTML::AttributeNames::width, DeprecatedString::number(width));
}
// https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-height
@ -196,9 +196,9 @@ unsigned HTMLImageElement::height() const
return 0;
}
void HTMLImageElement::set_height(unsigned height)
WebIDL::ExceptionOr<void> HTMLImageElement::set_height(unsigned height)
{
MUST(set_attribute(HTML::AttributeNames::height, DeprecatedString::number(height)));
return set_attribute(HTML::AttributeNames::height, DeprecatedString::number(height));
}
// https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-naturalwidth