RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

Ladybird: Scroll the JS console to the bottom on input

Browse source
This commit is contained in:
Sebastian Zaha 2023-07-18 17:03:39 +02:00 • committed by Linus Groh
parent d00f489cdc
commit 5d430b276c
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Ladybird/ConsoleWidget.cpp
View file

@ -159,9 +159,13 @@ void ConsoleWidget::print_html(StringView line)
document.body.appendChild(p); document.body.appendChild(p);
)~~~"sv); )~~~"sv);
// FIXME: Make it scroll to the bottom, using `window.scrollTo()` in the JS above. // FIXME: It should be sufficient to scrollTo a y value of document.documentElement.offsetHeight,
// We used to call `m_output_view->scroll_to_bottom();` here, but that does not work because // but due to an unknown bug offsetHeight seems to not be properly updated after spamming
// it runs synchronously, meaning it happens before the HTML is output via IPC above. // a lot of document changes.
//
// The setTimeout makes the scrollTo async and allows the DOM to be updated.
builder.append("setTimeout(function() { window.scrollTo(0, 1_000_000_000); }, 0);"sv);
m_output_view->run_javascript(builder.string_view()); m_output_view->run_javascript(builder.string_view());
} }