RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

Kernel: Rename Thread::clone() => try_clone() and propagate errors

Browse source
This commit is contained in:
Andreas Kling 2021-09-04 21:49:08 +02:00
parent cfc1a628d5
commit 5d5a3708c4
3 changed files with 20 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Kernel/Thread.cpp
View file

@ -50,11 +50,7 @@ KResultOr<NonnullRefPtr<Thread>> Thread::try_create(NonnullRefPtr<Process> proce
auto name = KString::try_create(process->name());
auto thread = adopt_ref_if_nonnull(new (nothrow) Thread(move(process), kernel_stack_region.release_nonnull(), block_timer.release_nonnull(), move(name)));
if (!thread)
return ENOMEM;
return thread.release_nonnull();
return adopt_nonnull_ref_or_enomem(new (nothrow) Thread(move(process), kernel_stack_region.release_nonnull(), block_timer.release_nonnull(), move(name)));
}
Thread::Thread(NonnullRefPtr<Process> process, NonnullOwnPtr<Memory::Region> kernel_stack_region, NonnullRefPtr<Timer> block_timer, OwnPtr<KString> name)
@ -1030,11 +1026,11 @@ RegisterState& Thread::get_register_dump_from_stack()
return *trap->regs;
}
RefPtr<Thread> Thread::clone(Process& process)
KResultOr<NonnullRefPtr<Thread>> Thread::try_clone(Process& process)
{
auto thread_or_error = Thread::try_create(process);
if (thread_or_error.is_error())
return {};
return thread_or_error.error();
auto& clone = thread_or_error.value();
auto signal_action_data_span = m_signal_action_data.span();
signal_action_data_span.copy_to(clone->m_signal_action_data.span());