RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:17:46 +00:00
Code Issues Activity Actions

AK: Fix FixedPoint to integral comparisons

Browse source 
Add tests to ensure that the fixed point numbers compare correctly to
integrals
This commit is contained in:
kleines Filmröllchen 2022-02-15 00:32:55 +01:00 • committed by Andreas Kling
parent f5fd2f3857
commit 5d6e3441fe
2 changed files with 29 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

28
AK/FixedPoint.h
View file

@ -261,42 +261,22 @@ public:
template<Integral I>
bool operator>(I other) const
{
if (m_value > 0)
return (m_value >> precision) > other || (m_value >> precision == other && (m_value & radix_mask));
if (other > 0)
return false;
return (m_value >> precision) > other || !(m_value >> precision == other && (m_value & radix_mask));
return !(*this <= other);
}
template<Integral I>
bool operator>=(I other) const
{
if (m_value > 0)
return (m_value >> precision) >= other || (m_value >> precision == other && (m_value & radix_mask));
if (other > 0)
return false;
return (m_value >> precision) >= other || !(m_value >> precision == other && (m_value & radix_mask));
return !(*this < other);
}
template<Integral I>
bool operator<(I other) const
{
if (m_value > 0)
return (m_value >> precision) < other || !(m_value >> precision == other && (m_value & radix_mask));
if (other > 0)
return true;
return (m_value >> precision) < other || (m_value >> precision == other && (m_value & radix_mask));
return (m_value >> precision) < other || m_value < (other << precision);
}
template<Integral I>
bool operator<=(I other) const
{
if (m_value > 0)
return (m_value >> precision) <= other || !(m_value >> precision == other && (m_value & radix_mask));
if (other > 0)
return true;
return (m_value >> precision) <= other || (m_value >> precision == other && (m_value & radix_mask));
return *this < other || *this == other;
}
// Casting from a float should be faster than casting to a float