RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00
Code Issues Activity Actions

LibJS: Support multiple arguments in Array.prototype.push()

Browse source
This commit is contained in:
Linus Groh 2020-04-13 16:45:59 +01:00 • committed by Andreas Kling
parent 9fab52a390
commit 5da1a40ccf
3 changed files with 35 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -37,9 +37,9 @@ namespace JS {
ArrayPrototype::ArrayPrototype()
{
put_native_function("shift", shift);
put_native_function("pop", pop);
put_native_function("pop", pop, 0);
put_native_function("push", push, 1);
put_native_function("shift", shift, 0);
put_native_function("toString", to_string, 0);
put("length", Value(0));
}
@ -65,9 +65,8 @@ Value ArrayPrototype::push(Interpreter& interpreter)
auto* array = array_from(interpreter);
if (!array)
return {};
if (!interpreter.argument_count())
return js_undefined();
array->elements().append(interpreter.argument(0));
for (size_t i = 0; i < interpreter.argument_count(); ++i)
array->elements().append(interpreter.argument(i));
return Value(array->length());
}

2
Libraries/LibJS/Runtime/ArrayPrototype.h
View file

@ -38,9 +38,9 @@ public:
private:
virtual const char* class_name() const override { return "ArrayPrototype"; }
static Value pop(Interpreter&);
static Value push(Interpreter&);
static Value shift(Interpreter&);
static Value pop(Interpreter&);
static Value to_string(Interpreter&);
};